code: Add new safe API for constructing a code #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #257 +/- ##
==========================================
+ Coverage 37.45% 37.83% +0.37%
==========================================
Files 18 18
Lines 3153 3214 +61
==========================================
+ Hits 1181 1216 +35
- Misses 1972 1998 +26 ☔ View full report in Codecov by Sentry. |
felinira
force-pushed
the
wip/code-safety
branch
from
ebcae79 to
77e6bdc
Compare
felinira
force-pushed
the
wip/code-safety
branch
5 times, most recently
from
e06cbe3 to
2342b5b
Compare
We require 4 bytes as an absolute minimum requirement on the code length now.
felinira
force-pushed
the
wip/code-safety
branch
from
5d6edce to
83fd169
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds new API for constructing a code with a reasonably safe entropy. We also deprecate the old methods to construct a code, and emit warnings on the usage of the old ones.
Closes #193